Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud_storage: use stable iterator for absl::btree #5704

Merged
merged 5 commits into from
Aug 2, 2022

Commits on Jul 28, 2022

  1. cloud_storage: use stable iterator

    absl::btree_map doesn't provide a pointer stability, so incerementing
    iterator in a loop that has a scheduling point can lead to segfault.
    remote_partition uses stable iterator that make a lookup on every
    iterator increment.
    Elena Anyusheva committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    4a98a1a View commit details
    Browse the repository at this point in the history
  2. cloud_storage: add gate guard to aborted_transactions

    Elena Anyusheva committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    76cd899 View commit details
    Browse the repository at this point in the history
  3. cloud_storage: fix typo in log

    Elena Anyusheva committed Jul 28, 2022
    Configuration menu
    Copy the full SHA
    dddff6e View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. cloud_storage: assert pointer in stable iterator increment

    remote_partition uses stable iterator wrapper for absl::btree. However
    stable iterator doesn't support deletions from the underlying btree_map.
    Add a comment about that.
    Elena Anyusheva committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b6ca1cf View commit details
    Browse the repository at this point in the history
  2. cloud_storage: don't capture reference to btree element

    Reference to the absl::btree_map is not stable, so don't use a reference
    that was captured before the scheduling point.
    Elena Anyusheva committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    28aab3f View commit details
    Browse the repository at this point in the history