Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: fix expected condition variable exception #5734

Merged
merged 1 commit into from
Jul 29, 2022

Commits on Jul 29, 2022

  1. consensus: fix expected condition variable exception

    The Seastar docs[1] say wait() returns condition_variable_timed_out, not
    timed_out_error. This resulted in error logs like:
    
    ```
    INFO  2022-07-29 00:03:16,777 [shard 0] raft - [group_id:5, {kafka/topic-fhmhqjvhxd/4}] consensus.cc:2757 - Starting leadership transfer from {id: {5}, revision: {32}} to {id: {4}, revision: {32}} in term 1
    INFO  2022-07-29 00:03:16,777 [shard 0] raft - [group_id:5, {kafka/topic-fhmhqjvhxd/4}] consensus.cc:2660 - transfer leadership: waiting for node {id: {4}, revision: {32}} to catch up
    ...
    ERROR 2022-07-29 00:03:26,777 [shard 0] rpc - Service handler threw an exception: seastar::condition_variable_timed_out (Condition variable timed out)
    // ... no corresponding message about the end of the leadership transfer
    ```
    
    [1] https://docs.seastar.io/master/classseastar_1_1condition__variable.html#a69703300a8e56a520269062f062aebda
    andrwng committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    9743adb View commit details
    Browse the repository at this point in the history