compat: add support for some tx types #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrwng
requested review from
dotnwat,
graphcareful,
ballard26 and
bharathv
and removed request for
ztlpn,
VadimPlh and
mmaslankaprv
graphcareful
previously approved these changes
Aug 4, 2022
andrwng
force-pushed
the
compat-tx
branch
3 times, most recently
from
388024c
to
e71e778
Compare
- cluster::commit_tx - cluster::abort_tx - cluster::begin_group_tx - cluster::prepare_group_tx
When running the test, I saw an error like: /home/andrew/Repos/redpanda/vbuild/llvm/install/bin/../include/c++/v1/__chrono/duration.h:97:59: runtime error: signed integer overflow: -9223372036854775808 * 1000000 cannot be represented in type 'long long' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/andrew/Repos/redpanda/vbuild/llvm/install/bin/../include/c++/v1/__chrono/duration.h:97:59 in Interestingly enough the test was happy to continue with the error and report OK, but still it's worth addressing.
|
@bharathv I updated one of your limit cases to use a clamped min/max duration. I'm not sure why it didn't fail the test, but running locally I spotted a UB error message. |
dotnwat
approved these changes
Aug 4, 2022
ya good catch.. I didn't notice it. |
bharathv
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Plugs some message types into the serde compat testing framework:
Backport Required
Release notes