cloud_storage: interrupt downloading segment #5847
Conversation
LenaAn
force-pushed
the
stream_copy
branch
2 times, most recently
from
91fd714
to
70447cf
Compare
| @@ -386,13 +391,15 @@ class copy_helper { | |||
| ss::output_stream<char> _output; | |||
| record_batch_transform_predicate _pred; | |||
| model::record_batch_header _header{}; | |||
| opt_abort_source_t _as; | |||
| }; | |||
|
|
|||
| ss::future<result<size_t>> transform_stream( | |||
There was a problem hiding this comment.
I think that in the end the abort_source is not passed in any of the transform_streams calls
There was a problem hiding this comment.
it's passed in offset_translator::copy_stream
|
Please clean up not needed includes. Also would be great to add a test where we drop all packets going out to minio and stop redpanda during this period. |
it doesn't stop just yet, will investigate further why UPD: it should stop after #5905 |
cloud_storage::remote may download a big segment and redpanda will not be stopped until the segment is fully downloaded. This commit adds an abort source that is passed to the offset_translator. partition_recovery_manager may interrupt segment download with this abort source.
|
Waiting until we cut 22.2.x to merge this |
|
CI failure is #5079 |
|
CI failure is #5358 |
|
/backport v21.11.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
/backport v22.1.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
will backport to 22.2 after we publish release |
Cover letter
cloud_storage::remote may download a big segment and redpanda will not
be stopped until the segment is fully downloaded. This commit adds an
abort source that is passed to the offset_translator.
partition_recovery_manager may interrupt segment download with this
abort source.
Backport Required
UX changes
Describe in plain language how this PR affects an end-user. What topic flags, configuration flags, command line flags, deprecation policies etc are added/changed.
Release notes