Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat: add support for more types #5855

Merged
merged 7 commits into from
Aug 5, 2022
Merged

compat: add support for more types #5855

merged 7 commits into from
Aug 5, 2022

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Aug 4, 2022 •
edited
Loading

Cover letter

Plugs more types into the compat testing framework:

  • create_non_replicable_topics_request
  • create_non_replicable_topics_reply
  • finish_partition_update_request
  • finish_partition_update_reply
  • cancel_all_partition_movements_request
  • cancel_partition_movements_reply
  • cancel_node_partition_movements_request
  • cancel_partition_movements_reply (used for both of the above request types)

Backport Required

  • not a bug fix
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

Release notes

  • none

@andrwng andrwng removed the request for review from mmaslankaprv August 4, 2022 21:29
@andrwng andrwng changed the title compat: add some type methods compat: add support for more types Aug 4, 2022
@andrwng
Copy link
Contributor Author

andrwng commented Aug 5, 2022

CI failure is #5742

@andrwng
tests: random generator for broker_shard
a570d25
@andrwng
compat: add json helpers for some types
f756cd1 
- cluster::move_cancellation_result
- cluster::non_replicable_topic
- cluster::topic_result
- model::topic_namespace
- model::broker_shard
@andrwng
compat: add create_non_replicable_topics messages
bc5a6b2
@andrwng
compat: add finish_partition_update messages
e7bb8cb
@andrwng
cluster: add cancel movement ostream operators
76eed69 
This is a part of the compat testing effort, wherein all serialized
types must have such operators.

- move_cancellation_results
- cancel_all_partition_movements_request
- partition_move_direction
- cancel_node_partition_movements_request
@andrwng
compat: add cancel partition movement messages
c42597f
@dotnwat
cluster: add some missing equality operators
3642158 
These are hard to detect because the serde::envelope defines one :(

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
dotnwat
dotnwat approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a commit on the end with some extra equality operators

@dotnwat
Copy link
Member

dotnwat commented Aug 5, 2022

Failure is #5868

@dotnwat dotnwat merged commit ba40e04 into redpanda-data:dev Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@bharathv bharathv Awaiting requested review from bharathv

@ballard26 ballard26 Awaiting requested review from ballard26

@graphcareful graphcareful Awaiting requested review from graphcareful

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrwng @dotnwat