Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpk: introduce rpk redpanda start --mode container #5940

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Aug 10, 2022

Cover letter

Introducing --mode container for rpk redpanda start

For full context, see PRD: https://docs.google.com/document/d/1qC6K0xvC3i3JgI-LMAWCyWlxQZ8KvM8ABthujWFDQ74

Usage

# Container Mode:
$ rpk redpanda start --mode container

# Mode Validation:
$ rpk redpanda start --mode foo
Error: unrecognized mode "foo", use --mode help for more info"

Documentation

$ rpk redpanda start --mode help
Mode uses well-known configuration properties for development or tests 
environments:

--mode container
    Bundled flags:
        * --overprovisioned
        * --reserve-memory 0M
        * --check=false
        * --unsafe-bypass-fsync
    Bundled cluster properties: 
        * auto_create_topics_enabled: true
        * group_topic_partitions: 3
        * storage_min_free_bytes: 10485760 (10MiB)
        * topic_partitions_per_shard: 1000

After redpanda starts you can modify the cluster properties using:
    rpk config set <key> <value>

Backport Required

  • v22.2.x

UX changes

  • overprovisioned is now enabled by default when Redpanda.DeveloperMode is enabled (redpanda.developer_mode : true in redpanda.yaml)

#5997 contains the latest release notes.

Release notes

  • none

This commit introduce --mode container for
redpanda start, it's a set of well-known
cluster properties and flags for dev/container
environments

We are now in the path of deprecating
redpanda.developer_mode, so if its enabled
we will default to '--mode container'.

Container mode include overprovisioned, thats
why we are also adding overprovisioned to the
config.Default() method.
@mmedenjak mmedenjak added the kind/enhance New feature or request label Aug 11, 2022
@r-vasquez
Copy link
Contributor Author

Failure is #5968

@r-vasquez r-vasquez merged commit 8a88a6e into redpanda-data:dev Aug 11, 2022
@r-vasquez
Copy link
Contributor Author

/backport v22.2.x

@BenPope
Copy link
Member

BenPope commented Aug 11, 2022

If there are no release notes, can you include the * none bit, please.

@r-vasquez
Copy link
Contributor Author

@BenPope I just added the release note, we iterated a bit with the naming/functionality of this feature and I forgot to add it at the end.

@r-vasquez r-vasquez deleted the sandbox-storage-v4 branch August 29, 2022 14:20
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 10, 2023
…storage-v4

rpk: introduce `rpk redpanda start --mode container`
joejulian pushed a commit to joejulian/redpanda that referenced this pull request Mar 24, 2023
…x-storage-v4

rpk: introduce `rpk redpanda start --mode container`
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants