tests: cleanup from ManyPartitionsTest improvements #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...use a single `map` instead of loops.
This is followup from PR redpanda-data#5816
jcsp
force-pushed
the
scale-test-update-followup
branch
from
c0b95f7
to
1689a72
Compare
dotnwat
approved these changes
Aug 15, 2022
| """ | ||
| if nodes is None and num_workers is None: | ||
| num_workers = 3 |
There was a problem hiding this comment.
dunno if mutual exclusion the param description should be verified with something like an else case asserting that both nodes and num_workers aren't non-None
|
CI failure is: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This is followup to #5816 to pick up some non-blocking improvements.
Backport Required
(backporting to keep other test backports easy rather than out of necessity)
UX changes
None
Release notes