tests: improve AdminOperationsFuzzer.wait #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztlpn
reviewed
Aug 12, 2022
| f"wait: terminating for error {self.error}") | ||
| raise self.error | ||
|
|
||
| if self.executed > count: |
There was a problem hiding this comment.
It is the same as in the original, but I think this should be >=?
There was a problem hiding this comment.
hmm, I guess it doesn't really matter as the test is waiting for an arbitrary number anyway, but yeah it's more intuitive to be >=, I'll update this.
This can drop out earlier when there is an error, rather than waiting in vain for the execution count to reach a target that it never will. Related: redpanda-data#5950
jcsp
force-pushed
the
issue-5950-timeouts
branch
from
65ebaef
to
e0ff6b9
Compare
ztlpn
approved these changes
Aug 12, 2022
dotnwat
approved these changes
Aug 14, 2022
| f"wait: terminating for error {self.error}") | ||
| raise self.error | ||
|
|
||
| if self.executed >= count: |
There was a problem hiding this comment.
the original predicate was self.executed > count. not sure if it really matters
There was a problem hiding this comment.
Yeah, this was a bit of drive-by cleanup to make the thing actually run count times (alexey's suggestion)
mmedenjak
added
kind/bug
|
/backport v22.2.x |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
This can drop out earlier when there is an error,
rather than waiting in vain for the execution count
to reach a target that it never will.
Related: #5950
Backport Required
UX changes
None
Release notes