More robust waiting for the quiescent state in partition balancer tests #6007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because unavailability timer resets every time the controller leader changes, robustly waiting for the timer to elapse is hard. Instead we simply wait until the unavailable node appears in the "violations" status field.
|
/ci-repeat 10 |
ivotron
added
the
ci-repeat-10
vbotbuildovich
removed
the
ci-repeat-10
Previously, when the controller leader node was suspended during the test all status requests would fail with the timed-out error. This was true for all nodes, not just the suspended one (because we proxy the status request to the controller leader), so internal retries in the admin API wrapper didn't help. We increase the timeout and add 504 to retriable status codes so that internal retries can handle this situation.
ztlpn
added
the
ci-repeat-10
vbotbuildovich
removed
the
ci-repeat-10
|
/ci-repeat 10 |
ztlpn
added
the
ci-repeat-10
vbotbuildovich
removed
the
ci-repeat-10
ZeDRoman
approved these changes
Aug 15, 2022
|
/backport v22.2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Because unavailability timer resets every time the controller leader changes, robustly waiting for the timer to elapse in the test context is hard. Instead we simply wait until the unavailable node appears in the "violations" status field.
Backport Required
UX changes
none
Release notes