[v22.2.x] admin: read-after-write consistency for config status on leader node #6049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, after writing a config update, API clients could do a /status query to the same node and not see any nodes (including the leader that they just PUT to) reflect the new version. With this change, if the client is talking to the controller leader, it will reliably see the new config version reflected in the /status result when querying the same node again after a PUT. This is a little subtle and later we should make simpler rules for this via a higher level "wait for status updates" as part of the PUT call itself: redpanda-data#5833 Related: redpanda-data#5609 (cherry picked from commit 6ba1128)
This tests the new behaviour in the previous commit. (cherry picked from commit c35eb1d)
If we query another node, it is possible to see persistent status updates for the nodes _other_ than the one we are querying, and non-persistent update to the stauts of the node we are querying, that passes the version check. Then if we query status on a different node a moment later, we will see an older state for the node we first queried. This only matters for tests that are actively trying to read the status _again_ after wait_for_version_sync. wait_for_version_sync was already correct inasmuchas when it complete the config has been applied everywhere. (cherry picked from commit 13d211a)
vbotbuildovich
requested review from
ztlpn,
NyaliaLui,
nicolaferraro,
VadimPlh and
mmaslankaprv
jcsp
approved these changes
Aug 17, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from pull request: #5835.