Validate under replicated metric after consumer is done #6184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the order of validation in full node recovery test. Now we first wait for all the messages to be consumed and only then check if recovery has finished. The change does not change the invariants validated in test but allow it to finish earlier. Fixes: redpanda-data#6151 Signed-off-by: Michal Maslanka <michal@redpanda.com>
When one of the nodes is isolated from the other it may be the case that rpk will always contact the isolated node when requesting cluster metadata, first node to contact is selected randomly. To give it more chance to ask other nodes made querying more often and increased a timeout. Signed-off-by: Michal Maslanka <michal@redpanda.com>
|
CI failure: #4702 |
|
I'm going to rebase and test it change before merging in |
5 tasks
rystsov
approved these changes
Aug 23, 2022
|
/backport v22.2.x |
This was referenced Sep 30, 2022
mmedenjak
added
kind/bug
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Change the order of validation in full node recovery test. Now we first
wait for all the messages to be consumed and only then check if recovery
has finished. The change does not change the invariants validated in
test but allow it to finish earlier.
Fixes: #6151
Fixes #ISSUE-NUMBER, Fixes #ISSUE-NUMBER, ...
Backport Required
UX changes
Describe in plain language how this PR affects an end-user. What topic flags, configuration flags, command line flags, deprecation policies etc are added/changed.
Release notes