Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ducktape] Fix connection rate test #6315

Merged
merged 2 commits into from
Sep 15, 2022
Merged

[ducktape] Fix connection rate test #6315

merged 2 commits into from
Sep 15, 2022

Conversation

VadimPlh
Copy link
Contributor

@VadimPlh VadimPlh commented Sep 5, 2022 •
edited
Loading

Cover letter

Problem

There are several problem with kaf_consumer.

  • Not predictable behavior for consume. (How much connection it does)
  • We need to stop it after start connection with redpanda by hand. It can take some time and influence on final resul

Changes

  1. Increasing number or iteration to get more precise time
  2. Use rpk_consumer. It is more predictable. Also wrapper for python code contains
    some useful logic:
  • max num messages to consume
  • stop if got error during consuming
  • internal retries

Fixes #6074
Fixes #5276

Backport Required

  • not a bug fix
  • issue does not exist in previous branches
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

UX changes

  • none

Release notes

  • none

@VadimPlh VadimPlh added the ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling label Sep 5, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling label Sep 5, 2022
dotnwat
dotnwat requested changes Sep 8, 2022
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the PR / commit messages with (1) why / what caused the CI failures and (2) how your changes fix those failures.

@VadimPlh VadimPlh added the ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling label Sep 9, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-5 repeat tests 5x concurrently to check for flakey tests; self-cancelling label Sep 9, 2022
@VadimPlh VadimPlh added the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label Sep 12, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label Sep 12, 2022
@VadimPlh VadimPlh added the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label Sep 12, 2022
@vbotbuildovich vbotbuildovich removed the ci-repeat-10 repeat tests 10x concurrently to check for flakey tests; self-cancelling label Sep 12, 2022
@VadimPlh VadimPlh changed the title Fix con rate test [duktape] Fix connection rate test Sep 12, 2022
@dotnwat dotnwat self-requested a review September 12, 2022 16:48
dotnwat
dotnwat previously requested changes Sep 12, 2022
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the PR / commit messages with (1) what caused the CI failures (or what the theory is) and (2) how your changes fix those failures.

@VadimPlh VadimPlh changed the title [duktape] Fix connection rate test [ducktape] Fix connection rate test Sep 13, 2022
@mmedenjak mmedenjak merged commit 1e5dbcc into redpanda-data:dev Sep 15, 2022
@BenPope
Copy link
Member

BenPope commented Oct 11, 2022

Maybe seen in https://buildkite.com/redpanda/redpanda/builds/15535#01835c07-d88b-4c36-ac91-fdabfba9cb59

@BenPope
Copy link
Member

BenPope commented Oct 11, 2022

/backport v22.2.x

This was referenced Oct 11, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcsp jcsp jcsp approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat

Assignees
No one assigned
Labels
area/tests ci-failure kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
6 participants
@VadimPlh @BenPope @dotnwat @jcsp @mmedenjak @vbotbuildovich