Heal network failures in the end of EndToEndFinjectorTest #6342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we did not heal network failures when exiting tests that use this base class (namely, AvailabilityTests). As possible failure types included netem failures, that meant that all subsequent tests in a test run used a node with crippled network, leading to flakiness. Fixes redpanda-data#5980
dotnwat
approved these changes
Sep 9, 2022
|
@ztlpn this PR marks #5980 as fixed. but looking at that issue it seems to be related to EDIT: nevermind, i missed that you wrote
nice find! |
|
Do we need to remove an |
|
/backport v22.2.x |
This was referenced Sep 9, 2022
|
/backport v22.1.x |
This was referenced Sep 9, 2022
mmedenjak
added
kind/bug
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Previously we did not heal network failures when exiting tests that use
EndToEndFinjectorTestbase class (namely,AvailabilityTests). As possible failure types included netem failures, that meant that all subsequent tests in a test run used a node with crippled network, leading to flakiness.The PR adds a
teardownmethod that heals all introduced network failures including netem ones.Fixes #5980
Backport Required
UX changes
none
Release notes