cluster: offset_monitor change custom exceptions to ss #6420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change custom exceptions that we made for offset montior to seastar default exceptions. It will help to deal with these exceptions in common way. simple_protocol will catch offset_monitor exceptions so they won't be logged as ERROR
|
Oops, looks like we both decided to work on this at almost exactly the same moment! #6419 |
mmedenjak
added
area/tests
ci-failure
kind/bug
|
Roman suggested via Slack that we merge #6419 instead, so closing this one. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Change custom exceptions that we made for offset monitor to seastar default exceptions.
It will help to deal with these exceptions in common way.
simple_protocol will catch offset_monitor exceptions so they won't be logged as ERROR
Fixes #5154
Backport Required