compaction: Extend max_collectible_offset check to adjacent compaction #6487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit test coverage that checks if adjacent compaction honors max_collectible_offset. The test fails at the current commit but should be fixed by the next one.
When selecting candidate pairs for adjacent compaction, makes sure all the participating segments pass the collectible offset check. This guarantees that the concatenated segment passes the same check.
Skips self compaction on a segment if the max collectible offset check fails. This serves as an additional guard rail in the actual compaction method even though callers themselves do similar checks.
dotnwat
reviewed
Sep 21, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Makes sure adjacent compaction honors max_collectible_offset check added in #5318. This is critical for transactions as we do not want to compact beyond LSO.
Fixes #6335
Backport Required
UX changes
Release notes
Features
Improvements