Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fixed setting si settings in read replica tests #6488

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

mmaslankaprv
Copy link
Member

Cover letter

Fixed incorrectly set shadow indexing properties in read replica tests.

Fixes: #6357

Backport Required

  • not a bug fix
  • issue does not exist in previous branches
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

UX changes

Describe in plain language how this PR affects an end-user. What topic flags, configuration flags, command line flags, deprecation policies etc are added/changed.

Release notes

  • none

Fixes: redpanda-data#6357

Signed-off-by: Michal Maslanka <michal@redpanda.com>
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we also remove ok_to_fail from the two tests that this change fixes (test_simple_end_to_end and test_produce_is_forbidden)?

@mmaslankaprv
Copy link
Member Author

LGTM. Should we also remove ok_to_fail from the two tests that this change fixes (test_simple_end_to_end and test_produce_is_forbidden)?

I didn't fixed the underlying issue that caused this test to fail. Just change the code not to access not existing variable. Maybe let's give it a bake time to see if the test will fail in say next 2 weeks.

@mmedenjak mmedenjak added kind/bug Something isn't working area/tests ci-failure area/cloud-storage Shadow indexing subsystem pr-blocker CI failures blocking a PR from being merged labels Sep 22, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cloud-storage Shadow indexing subsystem area/tests ci-failure kind/bug Something isn't working pr-blocker CI failures blocking a PR from being merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure in TestReadReplicaService's test_simple_end_to_end & test_produce_is_forbidden
3 participants