raft: use ss::timed_out_error in offset_monitor #6525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using this generic exception type loses us a little information on what kind of error occurred, but gains us the generic exception handling in the RPC layer that knows how to translate a seastar timeout into a kafka protocol timeout. Fixes: redpanda-data#6078
|
CI failure is #6329 This is fixing a test failure (via BadLogLines), so we should merge past it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Using this generic exception type loses us a little information on what kind of error occurred, but gains us the generic exception handling in the RPC layer that knows how to translate a seastar timeout into a kafka protocol timeout.
Fixes: #6078
Backport Required
UX changes
None
Release notes