Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin: return 503 on replication_error #6643

Merged
merged 1 commit into from
Oct 7, 2022
Merged

admin: return 503 on replication_error #6643

merged 1 commit into from
Oct 7, 2022

Conversation

andrwng
Copy link
Contributor

@andrwng andrwng commented Oct 5, 2022 •
edited
Loading

Cover letter

It's possible we get a replication_error in the admin server if we dispatch request to a node that loses leadership as it attempts to replicate_and_wait() the request to followers. This commit treats such errors as transient and retriable, and returns a 503.

Fixes #6642

Backport Required

  • not a bug fix
  • issue does not exist in previous branches
  • papercut/not impactful enough to backport
  • v22.2.x
  • v22.1.x
  • v21.11.x

UX changes

Describe in plain language how this PR affects an end-user. What topic flags, configuration flags, command line flags, deprecation policies etc are added/changed.

Release notes

@andrwng
admin: return 503 on replication_error
7f0767c 
It's possible we get a replication_error in the admin server if we
dispatch request to a node that loses leadership as it's attempting to
replicate the request to followers. This commit treats such errors as
transient and retriable, and returns a 503.
@andrwng
Copy link
Contributor Author

andrwng commented Oct 5, 2022

/ci-repeat 5

@dotnwat dotnwat requested a review from jcsp October 5, 2022 22:08
dotnwat
dotnwat approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me. i added @jcsp for a quick peek who is the http whisperer

@dotnwat
Copy link
Member

dotnwat commented Oct 5, 2022

@andrwng you might give the new ci-repeat a try here too. something like

/ci-repeat 5
debug
skip-units
dt-repeat=20
tests/rptest/tests/partition_balancer_test.py::PartitionBalancerTest.test_maintenance_mode

@mmedenjak mmedenjak added kind/bug Something isn't working ci-failure labels Oct 6, 2022
@andrwng
Copy link
Contributor Author

andrwng commented Oct 6, 2022

CI failures are:

@andrwng
Copy link
Contributor Author

andrwng commented Oct 6, 2022

/ci-repeat 5
debug
skip-units
dt-repeat=20
tests/rptest/tests/partition_balancer_test.py::PartitionBalancerTest.test_maintenance_mode

@andrwng andrwng merged commit c68a5c0 into redpanda-data:dev Oct 7, 2022
@andrwng andrwng deleted the replication-error-503 branch October 7, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@jcsp jcsp jcsp approved these changes

@graphcareful graphcareful graphcareful approved these changes

Assignees
No one assigned
Labels
area/redpanda ci-failure kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
5 participants
@andrwng @dotnwat @jcsp @graphcareful @mmedenjak