tests: remove code for saving executables on failure #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should no longer be necessary, because our buildkite jobs now retain build outputs as artifacts.
These are no longer saved by the test code after failure, they're saved by buildkite jobs as artifacts.
andrwng
approved these changes
Oct 17, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cover letter
Buildkite jobs used to throw away packages after tests ran, which made it hard to decode backtraces after the fact.
Recently the jobs were improved to save packages as artifacts, so we don't need to do this any more.
As well as removing some effectively dead code, this also helps to avoid bloating out results tarballs with redundant copies of executables when a crash happens.
Backport Required
UX changes
None
Release notes