operator/tests: waiting for deployment in each step is not needed #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the diff is really weird but I really just renamed all the file decrementing the steps numbers so 01 -> 00 etc. |
|
Couldn't we start our tests from |
|
@RafalKorepta yeah we could but why? Only to reduce diff on this PR? :) Since I already changed it we could do the "proper" indexing from 0 :) 🤷♀️ |
|
/gcbrun |
dimitriscruz
previously approved these changes
Mar 2, 2021
this is because we're already waiting for webhook to be ready during test suite setup and deployment and webhook run in the same process.
alenkacz
force-pushed
the
av/tests-no-wait
branch
from
54f5931
to
04b4eaa
Compare
dimitriscruz
approved these changes
Mar 2, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is because we're already waiting for webhook to be ready during test suite setup and deployment and webhook run in the same process.
fixes #655
Checklist
When referencing a related issue, remember to migrate duplicate stories from the
external tracker. This is not relevant for most users.