Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v22.1.x] rpc/transport: release caller units when timeout occurs #7325

Merged

Conversation

vbotbuildovich
Copy link
Collaborator

Backport from pull request: #6738.
Fixes #7324,

When request is completed with timeout we must release request related
caller passed semaphore units. Otherwise the units may be held in the
requests queue long enough to outlive the caller and cause use after
free error when released.

Fixes: redpanda-data#6711

Signed-off-by: Michal Maslanka <michal@redpanda.com>
(cherry picked from commit 8967962)
@vbotbuildovich vbotbuildovich added this to the v22.1.x-next milestone Nov 16, 2022
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Nov 16, 2022
@BenPope BenPope marked this pull request as ready for review November 16, 2022 21:39
@BenPope BenPope merged commit 616f744 into redpanda-data:v22.1.x Nov 16, 2022
@BenPope BenPope modified the milestones: v22.1.x-next, v22.1.10 Nov 16, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants