Commits on Nov 24, 2022

1. cloud_roles: ensures http client is always closed …

   The http client in cloud_roles::make_request was not closed when
   exception is thrown. RAII might usually be a better fit for ensuring the
   client is closed, but the client stop method returns a future which
   cannot be returned from/blocked on in destructor.
   
   This change introduces a helper modeled after ss::with_file to accept
   and own an http client and close it after a user-supplied operation is
   finished.
   
   It also adds a helper to wrap making an http request with catching and
   logging common http call errors.
   
   (cherry picked from commit 024ba8e)

   

   abhijat committed Nov 24, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 76709e5
   • Browse repository at this point

   Copy the full SHA

   76709e5 View commit details

   Browse the repository at this point in the history

2. cloud_roles: test for client closing cleanly …

   (cherry picked from commit dc5c9ef)
   
   automated cherry pick failed in
   redpanda-data#7015
   
   adjusted the http imposter to bring in only the required part of the api
   for the tests in backport.

   

   abhijat committed Nov 24, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for ad470c8
   • Browse repository at this point

   Copy the full SHA

   ad470c8 View commit details

   Browse the repository at this point in the history