[v22.3.x] cluster: allow seeds-driven bootstrap when empty_seed_starts_cluster=1 #7501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, empty_seed_starts_cluster=1 meant that the node was configured to use root-driven bootstrap and that it should expect some singular node in the cluster to have an empty seeds list. This is the default, and was mainly there for compatibility reasons. However, this default is currently explicitly incompatible with seeds-driven bootstrap, and thus is incompatible with having all node configurations in the cluster being identical. To encourage usage of seeds-driven bootstrap, and to allow homogeneous node configs by default, this commit makes empty_seed_starts_cluster=1 compatible with seeds-driven bootstrap. An empty seed_servers list still indicates that the configured node should be the root node, but seeds-driven bootstrap can be used with empty_seed_starts_cluster=1 if: - there exists no root node among any of the seeds, and - all seeds meet the existing requirements to perform seeds-driven bootstrap. (cherry picked from commit 4dcfee4)
This adds a simple test to make sure a cluster doesn't successfully form if empty_seed_starts_cluster is False but the seed_servers are configured with a root node. (cherry picked from commit a7fece6)
dlex
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #7390