Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster_bootstrap_tests test upgrade 22.2 -> 22.3, not -> newest #7542

Conversation

dlex
Copy link
Contributor

@dlex dlex commented Nov 28, 2022

This is to avoid skipping major versions in upgrade tests

Re #7310

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

  • none

Release Notes

  • none

@dlex dlex changed the title cluster_bootstrap_tests always test upgrade 22.2 -> 22.3 cluster_bootstrap_tests test upgrade 22.2 -> 22.3, not -> newest Nov 28, 2022
@dlex dlex marked this pull request as ready for review November 29, 2022 04:06
@dlex dlex requested a review from andrwng November 29, 2022 04:06
@andrwng
Copy link
Contributor

andrwng commented Nov 29, 2022

I don't think this is the right approach. A test that doesn't actually test dev doesn't serve much purpose, and we might as well just remove the test entirely, since it already exists and gets run in the v22.3.x branch. If anything, perhaps we should make the test walk through a series of upgrades, verifying the various invariants (that a cluster UUID exists, etc) between each.

@dlex
Copy link
Contributor Author

dlex commented Nov 29, 2022

Agree, it makes sense changing it in the way to upgrade to 22.3.latest, backport to 22.3 and then delete from dev.

@dlex dlex closed this Nov 29, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants