Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v22.1.x] storage: assert out on EIO in read #7703

Merged
merged 1 commit into from
Dec 12, 2022
Merged

[v22.1.x] storage: assert out on EIO in read #7703

merged 1 commit into from
Dec 12, 2022

Conversation

jcsp
Copy link
Contributor

@jcsp jcsp commented Dec 12, 2022

(cherry picked from commit 875faa4)

Backport 875faa4

Backports Required

  • none - not a bug fix
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v22.3.x
  • v22.2.x
  • v22.1.x

UX Changes

Release Notes

@jcsp jcsp added area/storage kind/backport PRs targeting a stable branch labels Dec 12, 2022
@jcsp jcsp mentioned this pull request Dec 12, 2022
Merged
6 tasks
@jcsp jcsp requested a review from andrwng December 12, 2022 11:23
@jcsp
storage: assert out on EIO in read
dd3a12c 
(cherry picked from commit 875faa4)
@jcsp
Copy link
Contributor Author

jcsp commented Dec 12, 2022

Unrelated CI failure.

@jcsp jcsp marked this pull request as ready for review December 12, 2022 18:26
andrwng
andrwng approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@andrwng andrwng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity, the conflict was caused by the coroutinization of the method in later branches.

@jcsp jcsp merged commit 9bf8c38 into redpanda-data:v22.1.x Dec 12, 2022
@jcsp jcsp deleted the v22.1.x-backport-7633 branch December 12, 2022 21:15
@BenPope BenPope added this to the v22.1.11 milestone Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrwng andrwng andrwng approved these changes

@dotnwat dotnwat Awaiting requested review from dotnwat dotnwat is a code owner

@VadimPlh VadimPlh Awaiting requested review from VadimPlh

Assignees
No one assigned
Labels
area/redpanda area/storage kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v22.1.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcsp @andrwng @BenPope