net: eliminate indirection through net::server:resources type
#7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
emaxerrno
reviewed
Dec 21, 2022
| virtual ss::future<> apply(resources) = 0; | ||
| virtual ss::future<> apply(ss::lw_shared_ptr<net::connection>) = 0; | ||
|
|
||
| server_probe& probe() { return _probe; } |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The structure
net::server:resourceswas a container for ashared_ptr<net::connection>and a reference to the underlying server and a selection of accessors for server resources.Where #7860 flattened the
net::protocolintonet::server, this change flattens connection handling. For example, in many cases accesses to the server through thenet::server:resourcesobject is made in the context thenet::serversubclass, and these resources can be accessed directly rather than requiring the extra hop through the resources object.Backports Required
UX Changes
Release Notes