Expand serde coverage #9816
Expand serde coverage #9816
Conversation
michael-redpanda
force-pushed
the
expand-serde-coverage
branch
5 times, most recently
from
5f11ad5
to
a7df33e
Compare
tests/docker/ducktape-deps.sh
Outdated
| @@ -37,6 +37,7 @@ function install_system_deps() { | |||
| npm \ | |||
| openssh-server \ | |||
| netcat-openbsd \ | |||
| protobuf-compiler \ | |||
There was a problem hiding this comment.
I wonder if we can/should use the one we build in the build, e.g.:
vbuild/debug/clang/rp_deps_install/bin/protoc
There was a problem hiding this comment.
I'll see if it's accessible within the docker container
There was a problem hiding this comment.
The docker container is built independent of Redpanda. Your local build of Redpanda is mounted within the containers when the cluster is composed.
There was a problem hiding this comment.
I've had huge problems getting an arbitrary version of protoc to generate code that works with an arbitrary version of a protobuf library dependency. That's across C++, Go, and Python. Maybe I'm just doing something wrong.
There was a problem hiding this comment.
I'm not as familiar with protobufs as I am with flatbuffers... I'm compiling with version A has such issues working with library version B, if they are at least "close".
Maybe the correct solution for docker, and anything, is to build and use the same protoc across all use cases. I can update the docker build script to do just that.
There was a problem hiding this comment.
Right, but protoc is already built. My well-known PR updates the Python lib to the same version as what we build for Redpanda. (Don't let the version number fool you).
There was a problem hiding this comment.
Right, but protoc is already built.
The build for the test Docker image doesn't reference any build artifacts for Redpanda. Instead, the container is mounted with your build directory as a volume after it is built.
(Don't let the version number fool you).
It did
michael-redpanda
force-pushed
the
expand-serde-coverage
branch
from
a7df33e
to
f834a30
Compare
Added java based client that will exercise the schema registry Signed-off-by: Michael Boquard <michael@redpanda.com>
Signed-off-by: Michael Boquard <michael@redpanda.com>
|
/cdt |
Signed-off-by: Michael Boquard <michael@redpanda.com>
Added golang serde client based off of Confluent's kafka-go library Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
expand-serde-coverage
branch
from
f834a30
to
8cc46f6
Compare
|
/cdt |
michael-redpanda
force-pushed
the
expand-serde-coverage
branch
from
8cc46f6
to
d037aae
Compare
|
/cdt |
michael-redpanda
force-pushed
the
expand-serde-coverage
branch
from
d037aae
to
d2b2901
Compare
|
/cdt |
Signed-off-by: Michael Boquard <michael@redpanda.com>
Created a SerdeClient BackgroundThreadService that will fire off the different clients based on which client type to use. Moved python_librdkafka_serde_client.py to the remote_scripts directory so it can be accessed in the docker container. Updated python_librdkafka_serde_client.py to have the same command line arguments as the other clients. Signed-off-by: Michael Boquard <michael@redpanda.com>
michael-redpanda
force-pushed
the
expand-serde-coverage
branch
from
d2b2901
to
8c3e3ec
Compare
|
/cdt |
|
/backport v23.1.x |
|
/backport v22.3.x |
|
Failed to run cherry-pick command. I executed the below command: |
|
/backport v22.2.x |
|
Failed to run cherry-pick command. I executed the below command: |
Expands test coverage of schema registry by adding in a Golang and Java based Kafka client to exercise the schema registry
Fixes #9211
Force push
95ea7d0:Force push
c32d751:Makefilethat was missedForce push
a2b9898:Force push
5f11ad5:Force push
a7df33e:Force push
f834a30:Force push
8cc46f6:Force push
d037aae:Force push
d2b2901:Force push
8c3e3ec:Backports Required
Release Notes