Issue 20/Fix tricky edge case #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
September 9, 2023 13:53
This will promote tranquility
These tests don't pass in this commit
They aren't used anywhere. Removed.
owenRiddy
force-pushed
the
issue-20/strip
branch
from
37797f1
to
908e502
Compare
|
Can you send me your email so I can send you the contributor agreement to sign? http://nathanmarz.com/contact/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in Issue #20. I took it as a hint and implemented this by stripping metadata rather than introducing new syntax.
This PR also sneaks in more hinting when a method fails to match the superclass for Issue #21 .
The docs said I need to sign something? I'm happy to sign things.