Cache the examples and speed up test runs #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lets us test without artifacts in the git index
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Not sure if this is truly needed, but I'm mainly testing if the cache is restored or not.
This is mostly testing to see if the caches are helping.
Big, if true.
timdorr
changed the title
aryaemami59
pushed a commit
to aryaemami59/react-redux
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the RN examples ballooned our test runs to 10+ minutes, which seems like a lot of overkill. But we were doing zero caching, so we got dinged with a full, from-scatch build on each run. Big ick.
Turns out, we don't really need to build an entire app. What we're testing is if Metro will bundle our build output. So, I'll make an equivalent RTK PR to simplify that build step drastically.
Update: Just made reduxjs/redux-toolkit#4266 to speed things up on that end