Remove outdated rule on single quotes in docs #3495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR reduxjs#1874, a mass replacement of angled single quotes ’ with ASCII single quotes ' was approved. Since then, the docs have contained a mixture of angled and ASCII single quotes: ``` $ git log -S’ --since="Mon Aug 1 16:45:58 2016 -0400" --pretty=oneline | wc -l 17 ``` so it does not make sense to state a rule on them.
|
Deploy preview for redux-docs ready! Built with commit b882ef2 |
|
I'm not even sure why we have this paragraph. We don't enforce this. (AFAIK, Prettier can't do this for us yet). Let's just get rid of it entirely. |
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
* Remove outdated rule on single quotes in docs In PR reduxjs#1874, a mass replacement of angled single quotes ’ with ASCII single quotes ' was approved. Since then, the docs have contained a mixture of angled and ASCII single quotes: ``` $ git log -S’ --since="Mon Aug 1 16:45:58 2016 -0400" --pretty=oneline | wc -l 17 ``` so it does not make sense to state a rule on them. * Remove typographic stuff we don't use anyways. Former-commit-id: 99bbd43 Former-commit-id: 4d3298d
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
* Remove outdated rule on single quotes in docs In PR reduxjs#1874, a mass replacement of angled single quotes ’ with ASCII single quotes ' was approved. Since then, the docs have contained a mixture of angled and ASCII single quotes: ``` $ git log -S’ --since="Mon Aug 1 16:45:58 2016 -0400" --pretty=oneline | wc -l 17 ``` so it does not make sense to state a rule on them. * Remove typographic stuff we don't use anyways. Former-commit-id: 99bbd43 Former-commit-id: 4d3298d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1874, a mass replacement of angled single quotes ’ with ASCII
single quotes ' was approved. Since then, the docs have contained a
mixture of angled and ASCII single quotes:
so it does not make sense to state a rule on them.