Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CircleCI 2.0 with shield and CodeCov with shield. #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MichaelDimmitt
Copy link

@MichaelDimmitt MichaelDimmitt commented Jul 4, 2018

72 percent code coverage, nice!
For an example of what it looks like, see my default branch, https://github.com/MichaelDimmitt/react-testing-talk

I will be adding to the documentation for this pull request after it has been merged or closed. To improve readability of the process for setting code coverage up on a create react app.

link1: code coverage from create react app issues page
link2: code coverage from create react app docs
link3: use yarn test instead of npm test

Was a bit more of a challenge because we are using CircleCI instead of travis. But no worries got it working.

Lastly, codecov needed to be curled to get the report sent to their website.

#see file: .circleci/config.yml
curl -s https://codecov.io/bash | bash

CodeCov and CircleCI service is free for open source projects.

@MichaelDimmitt MichaelDimmitt force-pushed the add-codecov branch 2 times, most recently from 4d8f5d0 to 3301c71 Compare July 16, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant