Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvs: add ARM64 build file generation #23

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Conversation

jkunkee
Copy link
Contributor

@jkunkee jkunkee commented Feb 8, 2019

With the introduction of ARM64 Windows desktop (Windows 10 on ARM), GYP's MSVS generator needs to understand how to emit matching VS project files. This change does that.

pylib/gyp/MSVSSettings.py Outdated Show resolved Hide resolved
GYP already understands ARM64 from the other platforms it supports, but
it did not properly generate ARM ASM rules for Visual Studio. This
change adds support for it, from including the right props sheet to
emitting MARMASM tags instead of MASM tags. The tags required plumbing
the target architecture through a few layers of abstractions so the
right file types could be associated with it.
@refack refack merged commit 7ebe057 into refack:master Feb 9, 2019
@refack
Copy link
Owner

refack commented Feb 9, 2019

Actually we should add a test for this...

@jkunkee
Copy link
Contributor Author

jkunkee commented Feb 9, 2019

I was thinking about that exact question yesterday. There are two big changes: VCXPROJ files can have ARM64 as the Platform and in the Configuration, and .S and .asm files should land in MARMASM tags.

@jkunkee
Copy link
Contributor Author

jkunkee commented Feb 10, 2019

There is a .S+.asm change in node/gyp that is important (nodejs/node@9920dbc).

Also, note that I submitted this change as nodejs/node#26020 so it can make it into Node faster, as advised by a contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants