Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[math function] Adding acos and acosh math functions #186

Merged
merged 1 commit into from
Apr 5, 2024
Merged

[math function] Adding acos and acosh math functions #186

merged 1 commit into from
Apr 5, 2024

Conversation

pratikmota
Copy link
Contributor

Changes:

  1. Adding support for acos and acosh math function
  2. Adding test cases of acos and acosh math function

Testing:
image

Test cases:
image

refaktor
refaktor approved these changes Apr 5, 2024
View reviewed changes
Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! And thank you for adding tests and examples! Also very nice that there are clear understandable error messages!

@refaktor refaktor merged commit 621f59d into refaktor:main Apr 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refaktor refaktor refaktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratikmota @refaktor