Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build and publish docker images through github CI #195

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

booniepepper
Copy link
Contributor

@booniepepper booniepepper commented Apr 23, 2024

I'm not sure if this is related to #194 but I don't see automation yet for publishing docker images, and wanted to contribute it.

Also not sure of a great way to test things like this, but feel free to grab me on discord (@booniepepper) if there are any issues

Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, I will test it soon with new release!

@refaktor refaktor merged commit 68fabd3 into refaktor:main Apr 23, 2024
7 checks passed
@stefanb
Copy link
Contributor

stefanb commented May 6, 2024

Not sure this is needed, as images are already built and published using goreleaser:

rye/.goreleaser.yaml

Lines 63 to 72 in 9a67814

kos: # See https://goreleaser.com/customization/ko/
- repository: ghcr.io/refaktor/rye
tags:
- '{{.Version}}'
- latest
bare: true
preserve_import_paths: false
platforms:
- linux/amd64
- linux/arm64

See https://github.com/refaktor/rye/pkgs/container/rye

It

  • may cause conflicts on next release
  • may cause confusion with users
  • only builds for amd64 platform

@stefanb
Copy link
Contributor

stefanb commented May 6, 2024

@booniepepper, can you please check if the existing released images at https://github.com/refaktor/rye/pkgs/container/rye are ok or is there something that should be changed / improved?

See https://github.com/refaktor/rye?tab=readme-ov-file#binary-docker-image

@booniepepper
Copy link
Contributor Author

There is some detail in #194 on testing previous versions and version 0.0.19

If there's something more specific, please create an issue, and I can take a look. I will almost certainly lose track of a conversation in a closed pull request

@stefanb
Copy link
Contributor

stefanb commented May 6, 2024

As far as i can tell the issue described in linked #194 now works fine:

docker run ghcr.io/refaktor/rye:latest -do "print 123 + 123"
Unable to find image 'ghcr.io/refaktor/rye:latest' locally
latest: Pulling from refaktor/rye
250c06f7c38e: Download complete
50967c6354e2: Download complete
01948aa61ab5: Download complete
Digest: sha256:e73d6d8a7c66dd65e578271e1fc4e625e992108b748f3103cc748dab034e6dfd
Status: Downloaded newer image for ghcr.io/refaktor/rye:latest
246

and

docker run --rm ghcr.io/refaktor/rye -do 'print "Hello"'
Hello

If this was the only problem i guess the changes from this PR can be safely reverted to prevent any conflicts with images built by goreleaser.

refaktor added a commit that referenced this pull request Aug 4, 2024
there was a error with release of new version and we think think it's related to this. Goreleaser should already publich to docker. We will check. More: #195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants