-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] <Show isLoading={true}> with Material UI doesn't show loading spinner #5668
Comments
Hello, I tried to recreate this bug. It is working as you said, there is no loading spinner. However, I think that is the expected behavior. When loading, the component doesn't show a loading spinner, but disables the refresh button. I found that here in the documentation: |
Thanks for the explanation, @issa012. As mentioned you can use this prop to disable refresh button. |
@rners01 While it's not a bug, we are open to contributions if someone would like to work on this one. |
I can try, if you assign this to me. |
Sure, assigned to you. 🚀 |
@BatuhanW Was the feature merged? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@omeraplak Can you assign it to @0xJaskeerat ? |
@0xJaskeerat assiged issue to you. |
I noticed this issue has been stale for a while. I can work on this, could you please assign it to me, @BatuhanW? Thanks! |
I'll leave a comment here to help anyone interested to work on this issue about what we want from the implementation. 🙏 This fix needs to be implemented for To avoid any layout shifts, we're recommending using some We can pass <Card
{...(wrapperProps ?? {})}
sx={{
position: "relative",
...wrapperProps?.sx,
}}
> Then we can place a {isLoading && (
<Box
sx={{
position: "absolute",
inset: 0,
display: "flex",
justifyContent: "center",
alignItems: "center",
zIndex: (theme) => theme.zIndex.drawer + 1,
// this is needed to support custom themes, dark mode etc.
bgcolor: (theme) => alpha(theme.palette.background.paper, 0.4),
}}
>
<CircularProgress />
</Box>
)} I'm not sure if this covers all the necessary cases but I guess it will be a good starting point for the implementation. We'll be happy to help if anyone is interested working on this issue. 🚀 |
@aliemir is this issue fixed? |
Hey @Anonymous961, your screenshot is from Ant Design. This issue is related with our Material UI CRUD components and its still looking for contributors 🙏 |
…/>` components. (refinedev#6271) (fixes refinedev#5668) Co-authored-by: Ali Emir Şen <senaliemir@gmail.com>
…/>` components. (refinedev#6271) (fixes refinedev#5668) Co-authored-by: Ali Emir Şen <senaliemir@gmail.com>
Describe the bug
<Show isLoading={true}>
with Material UI doesn't show loading spinnerSteps To Reproduce
Expected behavior
Spinner on
isLoading=true
Packages
"@refinedev/cli": "2.16.24",
"@refinedev/core": "4.47.1",
"@refinedev/kbar": "1.3.6",
"@refinedev/mui": "5.14.4",
"@refinedev/react-hook-form": "4.8.14",
"@refinedev/react-router-v6": "4.5.5",
"@refinedev/simple-rest": "5.0.2",
Additional Context
No response
The text was updated successfully, but these errors were encountered: