Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add Script for Remix SPA Mode #6127

Closed
YusukeSano opened this issue Jul 10, 2024 · 3 comments · Fixed by #6246 or #6253
Closed

[FEAT] Add Script for Remix SPA Mode #6127

YusukeSano opened this issue Jul 10, 2024 · 3 comments · Fixed by #6246 or #6253
Assignees
Labels
enhancement New feature or request

Comments

@YusukeSano
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In Remix SPA Mode, the scripts differ from those in the regular Remix setup.

"dev": "remix vite:dev",
"build": "remix vite:build",
"start": "vite preview",

Currently, the refine CLI only supports Remix SSR Mode.

Describe alternatives you've considered

Using npm-run-all.

Example: npm run dev

"devtools": "refine devtools",
"dev:remix": "remix vite:dev",
"dev": "npm-run-all --parallel devtools dev:remix",

Additional context

No response

Describe the thing to improve

Whether SPA Mode is enabled can be determined from vite.config.ts. While it would be ideal if getProjectType could detect this, it seems more reasonable to make it selectable through the platform option, as shown below:

refine dev -p remix-spa

@YusukeSano YusukeSano added the enhancement New feature or request label Jul 10, 2024
@BatuhanW
Copy link
Member

Hey @YusukeSano thanks for the report! It's a good suggestion, would you like to work on this?

@swethamanur
Copy link

@BatuhanW , if the issue is unassigned, could I work on this one please?

@YusukeSano
Copy link
Contributor Author

YusukeSano commented Aug 11, 2024

Apologies to @swethamanur, but our team needed this feature, so I created a pull request.

@aliemir aliemir added this to the September Release milestone Aug 13, 2024
aliemir added a commit that referenced this issue Aug 20, 2024
Co-authored-by: Ali Emir Şen <senaliemir@gmail.com>
@BatuhanW BatuhanW linked a pull request Sep 2, 2024 that will close this issue
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this issue Sep 4, 2024
emrecancorapci pushed a commit to emrecancorapci/refine that referenced this issue Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants