module-info: fix reversed job names! #4406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index in the array of jobs isn't the number! Before this change the "Job relative-ci#1" and "Job relative-ci#2" were reversed. Turns out, everywhere else we reference the jobs we always look up the label in the labels map. That wasn't being done here and thus the jobs were actually mis-labeled (2 was 1 and 1 was 2) making the chunk list in module-info attributed to the wrong job. Now it's fixed and the right job labels are show.
Job #10887: Bundle Size — 349.54KiB (~-0.01%).
Bundle metrics
|
| Current Job #10887 |
Baseline Job #10879 |
|
|---|---|---|
 Initial JS |
309.76KiB(~-0.01%) |
309.77KiB |
 Initial CSS |
39.78KiB |
39.78KiB |
 Cache Invalidation |
25.77% |
37.13% |
| Chunks |
3 |
3 |
| Assets |
4 |
4 |
| Modules |
660 |
660 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
35 |
35 |
| Duplicate Packages |
0 |
0 |
Bundle size by type 1 change 1 improvement
| Current Job #10887 |
Baseline Job #10879 |
|
|---|---|---|
| JS |
309.76KiB (~-0.01%) |
309.77KiB |
| CSS |
39.78KiB |
39.78KiB |
View job #10887 report View iFixit:module-info--fix-job-labe... branch activity View project dashboard
danielbeardsley
changed the title
|
Available on @danielbeardsley sent you an email to your profile's address ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index in the array of jobs isn't the number!
Before this change the
Job #1andJob #2were reversed.Turns out, everywhere else we reference the jobs we always look up the label in the labels map. That wasn't being done here and thus the jobs were actually mis-labeled (2 was 1 and 1 was 2) making the chunk list in module-info attributed to the wrong job.
Now it's fixed and the right job labels are show.
Here's an example of the bug (notice the different ordering in the jobs):
