Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rollback safer #881

Closed
ejholmes opened this issue Jun 14, 2016 · 3 comments
Closed

Make rollback safer #881

ejholmes opened this issue Jun 14, 2016 · 3 comments

Comments

@ejholmes
Copy link
Contributor

Right now, it's too easy to accidentally roll back to a really old release. Some ideas:

  1. Only allow rolling back up to 10 releases (e.g. if you're on v1130, you can only roll back v1120-v1129).
  2. Require confirmation when rolling back, and show a diff or something between the release versions.
@ejholmes ejholmes changed the title Set a limit on how the oldest release that can be rolled back Make rollback safer Jun 14, 2016
@mwildehahn
Copy link
Contributor

Asking for a confirmation if the release is greater than 10 releases ago makes sense. Not allowing someone to rollback to whatever version they want seems too restrictive. You could be setting a bunch of env vars or some other edge case.

We should be able to reuse some of the required commit message logic/code to do this

@Nosajool
Copy link
Contributor

The way I'm thinking of doing this is to do the validation client side.

  • Fetch current release version
  • If rolling back farther than 10 versions: "You are rolling back x versions to v123. If you would like to continue, type v123"

@ejholmes
Copy link
Contributor Author

👍 I think a pure client side solution for this is the right way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants