Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CreatedAt/UpdatedAt/StoppedAt from ECS API. #683

Merged
merged 2 commits into from
Dec 1, 2015
Merged

Conversation

ejholmes
Copy link
Contributor

Closes #682
Fixes #555

$ emp ps -a acme-inc
v1.web.02510d1a-ca9f-4bda-b9d4-d87e4e3a4b7f  1X  RUNNING  26s  "acme-inc server"
$ # kill task
$ emp ps -a acme-inc
v1.web.b46508ce-0aaf-4100-8192-268d6040182e  1X  RUNNING   2s  "acme-inc server"

Still need to test this. I'm not seeing the new fields returned with the aws CLI.

First commit is the actual changes, second is just godep updates.

Depends on remind101/kinesumer#20

Test

  • Log streaming still works.
  • stoppedAt/createdAt/startedAt are never nil.

@ejholmes
Copy link
Contributor Author

Tested this locally. *At fields weren't showing up for me in the CLI originally because of an old version.

@phobologic
Copy link
Contributor

👍 - what's with the new ConfigProvider & session stuff? Is this a change in the SDK that we should be using more regularly?

@ejholmes
Copy link
Contributor Author

ejholmes commented Dec 1, 2015

Yeah, v1.0 of the go aws sdk completely changed how you initialize clients.

ejholmes added a commit that referenced this pull request Dec 1, 2015
Use CreatedAt/UpdatedAt/StoppedAt from ECS API.
@ejholmes ejholmes merged commit 0c45926 into master Dec 1, 2015
@ejholmes ejholmes deleted the updated-at branch December 1, 2015 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants