-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Certificate Documentation #724
Conversation
Update documentation to cover new method for uploading certificates.
|
||
```console | ||
$ emp certs-attach arn:aws:iam::<accountId>:server-certificate/myServerCertificate -a <app> | ||
emp ssl-cert-add -a <app> cert.pem cert.key |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the old method :). Empire no longer supports cert uploads. See #701 for background.
We may re-introduce a command to upload certificates, but it would probably be per account instead of per app like it was before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok! Should we update the command list printed when running emp without any arguments? These methods are currently listed:
ssl show ssl endpoint info
ssl-cert-add add a new ssl cert
ssl-cert-rollback add a new ssl cert
ssl-destroy destroy ssl endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah! Good catch. These are supposed to be hidden, but it looks like they were still getting output from the usage. Opened a pr to fix that: #726
Thanks for the heads up!
Hey guys,
This outputs the following:
My current empire version is 0.9.2 and the old ssl commands seems not to be available anymore. Sincerely, |
Hey @hajimenomomo. This is happening because you're using a 0.9.3 client against a 0.9.2 daemon. Couple of things you can do:
|
There's a new emp command for uploading ssl certificates, update docs to cover this method instead.