Remove instanceof check from isRouteErrorResponse (#9930)

remix-run · Jan 18, 2023 · 7f85014 · 7f85014
1 parent 15ad8d5
commit 7f85014
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/.changeset/silver-snails-destroy.md b/.changeset/silver-snails-destroy.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/router": patch
+---
+
+Remove instanceof check from isRouteErrorResponse to avoid bundling issues on the server
diff --git a/packages/router/utils.ts b/packages/router/utils.ts
@@ -1395,8 +1395,14 @@ export class ErrorResponse {
 
 /**
  * Check if the given error is an ErrorResponse generated from a 4xx/5xx
- * Response throw from an action/loader
+ * Response thrown from an action/loader
  */
-export function isRouteErrorResponse(e: any): e is ErrorResponse {
-  return e instanceof ErrorResponse;
+export function isRouteErrorResponse(error: any): error is ErrorResponse {
+  return (
+    error != null &&
+    typeof error.status === "number" &&
+    typeof error.statusText === "string" &&
+    typeof error.internal === "boolean" &&
+    "data" in error
+  );
 }