Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a new router.routes identity during fog of war route patching #11740

Merged
merged 10 commits into from
Jun 27, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jun 27, 2024

This lets anything memoized via on router.routes update - such as Remix <Link prefetch> prefetching behavior - which will not prefetch initially, but will prefetch once the route has been discovered

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: 0b4f1bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

// HMR will already update the identity and reflow when it lands
// `inFlightDataRoutes` in `completeNavigation`
if (isNonHMR) {
dataRoutes = [...dataRoutes];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update router.routes identity during normal navigation discovery via unstable_patchRoutesOnMiss

Comment on lines +3344 to +3347
if (isNonHMR) {
dataRoutes = [...dataRoutes];
updateState({});
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update router.routes identity and reflow during eager router.patchRoutes flows

@brophdawg11 brophdawg11 merged commit eb30a88 into dev Jun 27, 2024
3 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fog-of-war-updates branch June 27, 2024 19:59
Copy link
Contributor

github-actions bot commented Jul 1, 2024

🤖 Hello there,

We just published version 6.24.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

github-actions bot commented Jul 3, 2024

🤖 Hello there,

We just published version 6.24.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant