Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wait for restore url navigation to complete before proceeding #11930

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Aug 26, 2024

Copies changes from @Artur- from #11620 but repoints to the v6 branch.

Because this relies on behavior of history which JSDOM doesn't correctly implement - I'm testing this through a Remix E2E test (which will be pulled into this Repo in RR v7): remix-run/remix#9914

Co-authored-by: Artur Signell <artur@vaadin.com>
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 4f435a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

brophdawg11 and others added 2 commits August 26, 2024 14:22
Co-authored-by: Artur Signell <artur@vaadin.com>
Co-authored-by: Artur Signell <artur@vaadin.com>
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🤖 Hello there,

We just published version 6.26.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

brophdawg11 added a commit that referenced this pull request Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

🤖 Hello there,

We just published version 6.26.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useBlocker fails when blocking function is quick to proceed
1 participant