Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative <Link to> #8087

Merged
merged 3 commits into from
Oct 14, 2021
Merged

Fix relative <Link to> #8087

merged 3 commits into from
Oct 14, 2021

Conversation

mjackson
Copy link
Member

Fixes relative <Link to> values so that .. traverses up by route instead of by URL segment.

Fixes #8086

@mjackson mjackson marked this pull request as draft September 30, 2021 00:43
@timdorr
Copy link
Member

timdorr commented Sep 30, 2021

FYI, I just noticed the yarn test command's return code was being swallowed by the single ampersand in the GH Actions run command. I split that into two commands on the dev branch, so you should rebase this to make sure that failing test actually fails.

@mjackson
Copy link
Member Author

Thanks for the heads up @timdorr 👍

@mjackson mjackson force-pushed the fix-relative-link-to branch 2 times, most recently from a85a9a8 to 837c5fe Compare September 30, 2021 18:20
@mjackson mjackson marked this pull request as ready for review October 14, 2021 09:54
@mjackson mjackson merged this pull request into dev Oct 14, 2021
@mjackson mjackson deleted the fix-relative-link-to branch October 14, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanflorence ryanflorence Awaiting requested review from ryanflorence

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjackson @timdorr