fix: add router UMD build for unpkg #9446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2275037 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
Oct 12, 2022
| @@ -86,7 +86,7 @@ module.exports = function rollup() { | |||
| banner: createBanner("React Router DOM v5 Compat", version), | |||
| globals: { | |||
| history: "HistoryLibrary", | |||
| "@remix-run/router": "Router", | |||
| "@remix-run/router": "RemixRouter", | |||
There was a problem hiding this comment.
The UMD name for the build is RemixRouter for clarity - Router felt a bit vague 😄
brophdawg11
commented
Oct 12, 2022
| "react-router", | ||
| "@remix-run/router", | ||
| ], | ||
| external: ["react", "react-dom", "react-router", "@remix-run/router"], |
There was a problem hiding this comment.
react-router-dom no longer depends on history so it can be removed from external and globals
brophdawg11
commented
Oct 12, 2022
| @@ -26,7 +26,7 @@ module.exports = function rollup() { | |||
| sourcemap: !PRETTY, | |||
| banner: createBanner("React Router", version), | |||
| }, | |||
| external: ["history", "@remix-run/router", "react"], | |||
| external: ["@remix-run/router", "react"], | |||
There was a problem hiding this comment.
Same for react-router, no longer depends on history
brophdawg11
commented
Oct 12, 2022
| getRollupConfig("esm", "router.js", { includeTypesAndCopy: true }), | ||
| getRollupConfig("cjs", "router.cjs.js"), | ||
| getRollupConfig("umd", "router.umd.js"), | ||
| getRollupConfig("umd", "router.umd.min.js", { minify: true }), |
There was a problem hiding this comment.
Add dev and prod UMD builds for @remix-run/router
mcansh
approved these changes
Oct 13, 2022
jacob-ebey
approved these changes
Oct 13, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a UMD build for
@remix-run/routersince that's needed for unpkg/UMD usage ofreact-router/react-router-domCloses #9240