Skip to content

Commit

Permalink
Don't retain the WebView, otherwise we get a retain cycle, because th…
Browse files Browse the repository at this point in the history
…e WebView owns us. This can lead to a crash on quit in +[WebView closeAllWebViews]
  • Loading branch information
lapcat committed Sep 6, 2009
1 parent 09f8430 commit cdc99e5
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions Plugin/Plugin.m
Original file line number Diff line number Diff line change
Expand Up @@ -1601,8 +1601,7 @@ - (WebView *)webView
}
- (void)setWebView:(WebView *)newValue
{
[newValue retain];
[_webView release];
// Not retained, because the WebView owns the plugin, so we'll get a retain cycle.
_webView = newValue;
}

Expand Down

0 comments on commit cdc99e5

Please sign in to comment.