Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tests, Js.Dict and Js.String to .res syntax #6349

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Aug 16, 2023

(Only js.ml and js_math.ml remaining in .ml syntax now because of some unexpected changes to release.ninja when converting those.)

@cknitt cknitt requested a review from cristianoc August 16, 2023 06:25
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@cknitt cknitt merged commit 5eb3e84 into rescript-lang:master Aug 16, 2023
14 checks passed
@cknitt cknitt deleted the tests-res branch August 16, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants