Notify-send slowdown

[hakavlad]

...if & not in the end of the command.

Replace
"-i dialog-warning 'earlyoom' 'Killing process %d %s'", victim_pid, victim_name);
with
"-i dialog-warning 'earlyoom' 'Killing process %d %s' &", victim_pid, victim_name);
will fix the problem

[hakavlad]

Earlyoom slowdowns until notify-send runs. Adding '&' fixes problem.

[rfjakob]

I see. But we also have to stop sending notifications until the first one is finished.

[rfjakob]

Otherwise we may spawn too many processes, and slow the system down even worse.

[hakavlad]

spawn too many processes, and slow the system down even worse

Have you seen this in fact even once?

[hakavlad]

Slowdown the system will stop after 1st SIGKILL.

[rfjakob]

Yes i have seen this with cronjobs that pile up. The server then enters a death spiral

[rfjakob]

earlyoom was sending the notification first, and kills later. As sending the notification needs memory, this was stupid. The change b2fe57c kills first, and notifies later. Does this fix the slowdown you see?

[hakavlad]

I need test it, I try it later.

[rfjakob]

PS: c91dc9e

[hakavlad]

Thank you very much

[hakavlad]

kills first, and notifies later. Does this fix the slowdown you see?

Works great, thanks!

[rfjakob]

Thanks for testing!

[hakavlad]

@rfjakob

Otherwise we may spawn too many processes, and slow the system down even worse.

I ran even

while true; do (notify-send lol &); done

and nothing happened.
Notify-send is very short-life process, it just quickly send info to notification daemon and die.
That's why using Popen and & seems like not dangerous.

[rfjakob]

That contradicts what you saw in #73 (comment) , right?