Make #create_column_definition a private method

* Fix method signature
rgeo · Nov 4, 2014 · 0b1a656 · 0b1a656
1 parent a0badaf
commit 0b1a656
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/lib/active_record/connection_adapters/postgis_adapter/spatial_table_definition.rb b/lib/active_record/connection_adapters/postgis_adapter/spatial_table_definition.rb
@@ -9,7 +9,7 @@ def initialize(types, name, temporary, options, as, adapter)
           super(types, name, temporary, options, as)
         end
 
-        def column(name, type = nil, options = {})
+        def column(name, type, options = {})
           if (info = @adapter.spatial_column_constructor(type.to_sym))
             type = options[:type] || info[:type] || type
             if type.to_s == 'geometry' && (options[:no_constraints] || options[:limit].is_a?(::Hash) && options[:limit][:no_constraints])
@@ -47,14 +47,6 @@ def column(name, type = nil, options = {})
           self
         end
 
-        def create_column_definition(name, type)
-          if type == :spatial || type == :geography
-            PostGISAdapter::ColumnDefinition.new(name, type)
-          else
-            super
-          end
-        end
-
         def non_geographic_spatial_columns
           @spatial_columns_hash.values
         end
@@ -67,6 +59,15 @@ def geography(name, options = {})
           column(name, :geography, options)
         end
 
+        private
+
+        def create_column_definition(name, type)
+          if %i[spatial geography].include?(type)
+            PostGISAdapter::ColumnDefinition.new(name, type)
+          else
+            super
+          end
+        end
       end
 
       class ColumnDefinition < PostgreSQL::ColumnDefinition  # :nodoc: