Remove implementation of no_constraints in main_adapter #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove skipped tests in `test/ddl_test.rb` that test now unsupported
(as of PostGIS 2.0) `no_constraints`
* Remove implementation of `no_constraints` in `main_adapter`
* Create private `set_dimensions` method in `main_adapter`
* Refactor `main_adapter#add_column` method to use private
`add_spatial_column` method
teeparham
added a commit
that referenced
this pull request
May 28, 2014
Remove implementation of no_constraints in main_adapter
|
👍 |
teeparham
added a commit
that referenced
this pull request
Nov 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the implementation of
no_constraintsinmain_adapter. This is potentially a non-backwards compatible change but the functionality is not being tested for as is (the tests were skipped) so it seems prudent to remove the implementation as well as the tests. The other changes are refactorings that do not affect the class' behavior.test/ddl_test.rbthat test now unsupported(as of PostGIS 2.0)
no_constraintsno_constraintsinmain_adapterset_dimensionsmethod inmain_adaptermain_adapter#add_columnmethod to use privateadd_spatial_columnmethodI'm using this gem on a project and am getting up to speed so I can contribute. Thanks.